[Pacemaker] Resource capacity limit

[Yan Gao]

Hi Andrew,
Thanks for your reply!

Andrew Beekhof wrote:
> On Wed, Nov 4, 2009 at 5:41 PM, Lars Marowsky-Bree <lmb at suse.de> wrote:
>> On 2009-11-03T19:15:59, Yan Gao <ygao at novell.com> wrote:
>>
>>> XML sample:
>>> ..
>>>     <nodes>
>>>       <node id="yingying" type="normal" uname="yingying">
>>>         <utilization id="nodes-yingying-utilization">
>>>           <nvpair id="nodes-yingying-memory" name="memory" value="150"/>
>>>           <nvpair id="nodes-yingying-cpu" name="cpu" value="1"/>
>>>         </utilization>
>>>       </node>
>>>     </nodes>
>>> ..
>>>     <resources>
>>>       <primitive class="ocf" id="Dummy0" provider="heartbeat" type="Dummy">
>>>         <utilization id="Dummy0-utilization">
>>>           <nvpair id="Dummy0-utilization-memory" name="memory" value="90"/>
>>>           <nvpair id="Dummy0-utilization-cpu" name="cpu" value="1"/>
>>>         </utilization>
>>>       </primitive>
>>>       <primitive class="ocf" id="Dummy1" provider="heartbeat" type="Dummy">
>>>         <utilization id="Dummy1-utilization">
>>>           <nvpair id="Dummy1-utilization-memory" name="memory" value="60"/>
>>>           <nvpair id="Dummy1-utilization-cpu" name="cpu" value="1"/>
>>>         </utilization>
>>>       </primitive>
>>>     </resources>
>>> ..
>>>
>>> Please kindly review it...
>>> Any suggestions are appreciated!
>> I think this is exactly what we need. Great job!
>>
>> Code looks good too.
>>
>> Andrew?
> 
> Four things...
> 
> Do we still need the limit-utilization option?
> I guess it might be nice to be able to turn it off globally... was
> that the intention here?
Sorry, missed it in the sample, while it has been implemented in the codes:-)
Yes, it's "limit-utilization" property, and default to "false".
So the working XML sample should be :
..
    <crm_config>
      <cluster_property_set id="cib-bootstrap-options">
        ...
        <nvpair id="cib-bootstrap-options-limit-utilization" name="limit-utilization" value="true"/>
      </cluster_property_set>
    </crm_config>
    <nodes>
      <node id="yingying" type="normal" uname="yingying">
        <utilization id="nodes-yingying-utilization">
          <nvpair id="nodes-yingying-memory" name="memory" value="150"/>
          <nvpair id="nodes-yingying-cpu" name="cpu" value="1"/>
        </utilization>
      </node>
    </nodes>...
    <resources>
      <primitive class="ocf" id="Dummy0" provider="heartbeat" type="Dummy">
        <utilization id="Dummy0-utilization">
          <nvpair id="Dummy0-utilization-memory" name="memory" value="90"/>
          <nvpair id="Dummy0-utilization-cpu" name="cpu" value="1"/>
        </utilization>
      </primitive>
      <primitive class="ocf" id="Dummy1" provider="heartbeat" type="Dummy">
        <utilization id="Dummy1-utilization">
          <nvpair id="Dummy1-utilization-memory" name="memory" value="60"/>
          <nvpair id="Dummy1-utilization-cpu" name="cpu" value="1"/>
        </utilization>
      </primitive>
    </resources>
..

> 
> The next one is minor, there should at least be a debug message when
> we filter out a node in native_color()
> Thats the sort of thing thats going to mess with people :-)
Indeed :-) Added one and attached the revised patch.
> 
> There also needs to be some PE regression tests for this (and be sure
> to run the existing ones to make sure they don't break).
Right.

> 
> Lastly, I would really like to defer this for 1.2
Agree too.

> I know I've bent the rules a bit for 1.0 in the past, but its really
> late in the game now.
> 
> Which reminds me, I need to get devel sorted out...
:-)

Thanks again!

Best regards,
  Yan
-- 
ygao at novell.com
Software Engineer
China Server Team, OPS Engineering

Novell, Inc.
Making IT Work As One™
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pacemaker-utilization-limit.patch
Type: text/x-patch
Size: 8878 bytes
Desc: not available
URL: <https://lists.clusterlabs.org/pipermail/pacemaker/attachments/20091106/beeb8fe2/attachment-0001.bin>