[ClusterLabs] [Problem] crm_attirbute fails to expand run options.

[Reid Wahl]

On Mon, Mar 6, 2023 at 11:42 PM <renayama19661014 at ybb.ne.jp> wrote:
>
> Hi All,
>
> The crm_attribute command expands the contents of options from the OCF_RESOURCE_INSTANCE environment variable if the p option is not specified.
>
> However, if -INFINITY is specified as the value of the v option at this time, crm_attributes will incorrectly expand -INFINITY as an option and processing will fail.
>
> ----
> [root at rh91-01dev tools]# crm_attribute -p pgsql  -v 100
> [root at rh91-01dev tools]# crm_attribute -p pgsql  -v -INFINITY
>
> [root at rh91-01dev tools]# OCF_RESOURCE_INSTANCE=pgsql crm_attribute -p  -v 100
> [root at rh91-01dev tools]# OCF_RESOURCE_INSTANCE=pgsql crm_attribute -p  -v -INFINITY
> crm_attribute: Could not map name=FINITY to a UUID
>
> ----
>
> This problem occurs with the latest resource agent running on RHEL9.1, but also with the development version of pacemaker.
>
>
> Due to this issue, some resource agents such as pgsql will fail to configure a cluster after version 4.12.
>
> It's a very serious problem.
>
> RAs such as pgsql should be run with the p option(OCF_RESOURCE_INSTANCE) provisionally when paired with a pacemaker version that does not resolve this issue.
> ----
> (snip)
> ocf_promotion_score() {
>         ocf_version_cmp "$OCF_RESKEY_crm_feature_set" "3.10.0"
>         res=$?
>         if [ $res -eq 2 ] || [ $res -eq 1 ] || ! have_binary "crm_master"; then
>                 ${HA_SBIN_DIR}/crm_attribute -p $OCF_RESOURCE_INSTANCE $@
>         else
>                 ${HA_SBIN_DIR}/crm_master -l reboot $@
>         fi
> (snip)
> ----
>
> This content has also been registered in the following Bugzilla:
> https://bugs.clusterlabs.org/show_bug.cgi?id=5509
>
> Best Regards,
> Hideo Yamauchi.
>
Thanks for the report! Can you test this?
https://github.com/ClusterLabs/pacemaker/pull/3039

> _______________________________________________
> Manage your subscription:
> https://lists.clusterlabs.org/mailman/listinfo/users
>
> ClusterLabs home: https://www.clusterlabs.org/
>


-- 
Regards,

Reid Wahl (He/Him)
Senior Software Engineer, Red Hat
RHEL High Availability - Pacemaker