[ClusterLabs] [EXT] Re: Feedback wanted: OCF Resource Agent API 1.1 proposed for adoption

[Ulrich Windl]

On 3/26/21 11:17 PM, Ken Gaillot wrote:
> OCF 1.1 is now formally adopted!
> 
> https://github.com/ClusterLabs/OCF-spec/blob/master/ra/1.1/resource-agent-api.md
> 
> Thanks to everyone who gave feedback.

"The minor number can be used by both sides to see whether a certain 
additional feature is supported by the other party."

That would mean there's a precise revision history with all features 
changed. I doubt such a thing exists yet, and the mistakes made in the 
past (like chaging the XML without changing the version) can't be 
corrected either. ;-)

"Actions must be idempotent." Well: if a "start" action fails, does it 
have to fail the next time, too? Maybe it's "Successful Actions must be 
idempotent."
Maybe even "Successful state-changing Actions must be idempotent."
("Monitor" most likely isn't idempotent; otherwise you would get the 
same status all the time, right?)

"Multiple resource instances of the same type may be running in parallel."

What about "Multiple concurrent actions for separate resource instances 
(using the same RA) must be handled correctly." instead?

What about listing allowable exit codes with each action?

Are there any metadata provisions for reporting the OCF_CHECK_LEVEL?

I don't quite understand exit codes 190 and 191. Maybe add an example.

"must at least support XML output": Is there any format other than XML 
specified? If not the statement doesn't make sense.

What about line-wrapping and other formatting usable in <longdesc>?
What about lengths for <shortdesc>?

The Semantics are under-specified IMHO. Example <desc> vs. <shortdesc>?

IMHO it would be best to specify exactly what is allowed; everything 
that isn't allowed is forbidden.
(That's better tan allowing some things and forbidding others, leaving a 
"gray zone" in between)

Regards,
Ulrich