[ClusterLabs] Antw: [EXT] Re: Q: high-priority messages from DLM?

[Reid Wahl]

Yeah I agree with you on all points, unless the author had a reason
for those decisions 15 years ago. Most of us do our best to avoid
touching DLM :)

If anyone wants to make changes to the DLM logging macros, I'm in
favor of it. I'm just not gonna lead the charge on it.

On Tue, Dec 8, 2020 at 12:01 AM Ulrich Windl
<Ulrich.Windl at rz.uni-regensburg.de> wrote:
>
> >>> Reid Wahl <nwahl at redhat.com> schrieb am 04.12.2020 um 19:33 in Nachricht
> <CAPiuu9-TCnj6qrfdwp_F6gE7R2x23WFU-FCbWKhbG7z=5wr=uA at mail.gmail.com>:
> > On Fri, Dec 4, 2020 at 10:32 AM Reid Wahl <nwahl at redhat.com> wrote:
> >>
> >> I'm inclined to agree, although maybe there's a good reason. These get
> >> logged with KERN_ERR priority.
> >
> > I hit Enter and that email sent instead of line‑breaking... anyway.
> >
> > https://github.com/torvalds/linux/blob/master/fs/dlm/dlm_internal.h#L61‑L62
>
> > https://github.com/torvalds/linux/blob/master/fs/dlm/lowcomms.c#L1250
>
> So everything log_print() outputs is an error? IMHO log_print is missing the
> priority/severity parameter...
> Comparing log_print(), log_error() and log_debug() I think that loggin code
> could benefit from some refactoring.
>
> Back on the subject:
> I think "Using SCTP for communications" is informational, not error, just as
> "closing connection to node 118" is probably notice, while "connecting to" /
> "connected to" is probably info or notice, too.
>
> Regards,
> Ulrich
>
> >
> >>
> >> On Fri, Dec 4, 2020 at 5:32 AM Ulrich Windl
> >> <Ulrich.Windl at rz.uni‑regensburg.de> wrote:
> >> >
> >> > Hi!
> >> >
> >> > Logging into a server via iDRAC, I see several messages drom "dlm:" at
> the
> > console screen. My obvious explanation is that they are on the screen,
> > because journald (SLES15 SP2) treats them is high priority messages that
> > should go to the screen. However IMHO they are not:
> >> >
> >> > [83035.333382] dlm: closing connection to node 118
> >> > [84756.045008] dlm: closing connection to node 118
> >> > [160906.211673] dlm: Using SCTP for communications
> >> > [160906.239357] dlm: connecting to 118
> >> > [160906.239807] dlm: connecting to 116
> >> > [160906.241432] dlm: connected to 116
> >> > [160906.241448] dlm: connected to 118
> >> > [174464.522831] dlm: closing connection to node 116
> >> > [174670.058912] dlm: connecting to 116
> >> > [174670.061373] dlm: connected to 116
> >> > [175561.816821] dlm: closing connection to node 118
> >> > [175617.654995] dlm: connecting to 118
> >> > [175617.665153] dlm: connected to 118
> >> > [175695.310971] dlm: closing connection to node 118
> >> > [175695.311039] dlm: closing connection to node 116
> >> > [175695.311084] dlm: closing connection to node 119
> >> > [175759.045564] dlm: Using SCTP for communications
> >> > [175759.052075] dlm: connecting to 118
> >> > [175759.052623] dlm: connecting to 116
> >> > [175759.052917] dlm: connected to 116
> >> > [175759.053847] dlm: connected to 118
> >> > [432217.637844] dlm: closing connection to node 119
> >> > [432217.637912] dlm: closing connection to node 118
> >> > [432217.637953] dlm: closing connection to node 116
> >> > [438872.495086] dlm: Using SCTP for communications
> >> > [438872.499832] dlm: connecting to 118
> >> > [438872.500340] dlm: connecting to 116
> >> > [438872.500600] dlm: connected to 116
> >> > [438872.500642] dlm: connected to 118
> >> > [779424.346316] dlm: closing connection to node 116
> >> > [780017.597844] dlm: connecting to 116
> >> > [780017.616321] dlm: connected to 116
> >> > [783118.476060] dlm: closing connection to node 116
> >> > [783318.744036] dlm: connecting to 116
> >> > [783318.756923] dlm: connected to 116
> >> > [784893.793366] dlm: closing connection to node 118
> >> > [785082.619709] dlm: connecting to 118
> >> > [785082.633263] dlm: connected to 118
> >> >
> >> > Regards,
> >> > Ulrich
> >> >
> >> >
> >> >
> >> > _______________________________________________
> >> > Manage your subscription:
> >> > https://lists.clusterlabs.org/mailman/listinfo/users
> >> >
> >> > ClusterLabs home: https://www.clusterlabs.org/
> >> >
> >>
> >>
> >> ‑‑
> >> Regards,
> >>
> >> Reid Wahl, RHCA
> >> Senior Software Maintenance Engineer, Red Hat
> >> CEE ‑ Platform Support Delivery ‑ ClusterHA
> >
> >
> >
> > ‑‑
> > Regards,
> >
> > Reid Wahl, RHCA
> > Senior Software Maintenance Engineer, Red Hat
> > CEE ‑ Platform Support Delivery ‑ ClusterHA
> >
> > _______________________________________________
> > Manage your subscription:
> > https://lists.clusterlabs.org/mailman/listinfo/users
> >
> > ClusterLabs home: https://www.clusterlabs.org/
>
>
>
> _______________________________________________
> Manage your subscription:
> https://lists.clusterlabs.org/mailman/listinfo/users
>
> ClusterLabs home: https://www.clusterlabs.org/



-- 
Regards,

Reid Wahl, RHCA
Senior Software Maintenance Engineer, Red Hat
CEE - Platform Support Delivery - ClusterHA