[ClusterLabs] Antw: Re: Antw: Re: Q: ocf:pacemaker:NodeUtilization monitor

[Ulrich Windl]

>>> Andrei Borzenkov <arvidjaar at gmail.com> schrieb am 29.05.2019 um 20:31 in
Nachricht <1d0c775a-6854-bede-e241-8c23d5919769 at gmail.com>:
> 29.05.2019 11:12, Ulrich Windl пишет:
>>>>> Jan Pokorný <jpokorny at redhat.com> schrieb am 28.05.2019 um 16:31 in
>> Nachricht
>> <20190528143145.GA29171 at redhat.com>:
>>> On 27/05/19 08:28 +0200, Ulrich Windl wrote:
>>>> I copnfigured ocf:pacemaker:NodeUtilization more or less for fun, and I 
>>> realized that the cluster rrepiorts no problems, but in syslog I have
these
>> 
>>> unusual messages:
>>>> 2019‑05‑27T08:21:07.748149+02:00 h06 lrmd[16599]:   notice: 
>>> prm_node_util_monitor_300000:15028:stderr [ info: Writing node
(dir)Top...
>> ]
>>>> 2019‑05‑27T08:21:07.748546+02:00 h06 lrmd[16599]:   notice: 
>>> prm_node_util_monitor_300000:15028:stderr [ info: Cannot find node
`(dir)GNU
>> 
>>> Free Documentation License'. ]
>>>> 2019‑05‑27T08:21:07.748799+02:00 h06 lrmd[16599]:   notice: 
>>> prm_node_util_monitor_300000:15028:stderr [ info: Done. ]
>>>>
>>>>
>>>> "(dir)" looks a lot like Documentation. What has the monitor to do with 
>>> documentation?
>>>
>>> The above looks as if you run "info" without arguments (it will try
>>> to dispay initial page '(dir)Top' ‑‑ and moreover perhasp when it is
>>> not found).
>>>
>>> I have no idea how this could happen, since there's the only reference
>>> to "info" and it seems basic‑sanity guarded:
>>>
>>>
>> 
>
https://github.com/ClusterLabs/resource‑agents/blob/v4.2.0/heartbeat/NodeUtil

>> 
>>> ization#L119
>>>
>>>> 118     if [ ‑x $xentool ]; then
>>>> 119         $xentool info | awk
>> '/total_memory/{printf("%d\n",$3);exit(0)}'
>>>> 120     else
>>>> 121         ocf_log warn "Can only set hv_memory for Xen hypervisor"
>>>> 122         echo "0"
>>>
>>> So kind of a mystery :‑)
>> 
>> Except when $xentool is undefined ;-)
> 
> How can condition [ -x $xentool ] be true then? Unless there actually is

Easy actually: Try " [ -x ] && echo 1": To my surprise it did not give a
syntax error (The correct usage would be '[ -x "" ] && echo 1' anyway.

> binary with name "]" and it happened to be in local directory (whatever
> local directory is when this script is executed).

Regards,
Ulrich