[ClusterLabs] Incorrect manual page for crm_failcount (SLES11 SP4)

[Ken Gaillot]

On Mon, 2018-09-03 at 11:57 +0200, Ulrich Windl wrote:
> Hi!
> 
> I just discovered an incorrect manual page for crm_failcount: The
> manual page describes an option the command does not support.
> 
>    Commands:
>        -G, --query
>               Query the current value of the attribute/option

That is a known issue that was fixed in 1.1.17 via commit 95db106

> When I tried --query, I got:
> # crm_failcount --query --resource=prm_stonith_sbd\:1 --node=h02 --
> quiet
> crm_failcount: unrecognized option '--query'
> crm_failcount - A convenience wrapper for crm_attribute
> [...]
> 
> However when I try -G, it worked:
> # crm_failcount -G --resource=prm_stonith_sbd\:1 --node=h02 --quiet
> 0
> 
> 
> The bug is in two places:
> 
> 1:
> TEMP=`getopt -o DGQVN:U:v:i:l:r: --long help,version,resource-
> id:,node:,uname:,a
> ttr-value:,delete-attr,get-value,attr-id:,lifetime:,quiet \
>      -n 'crm_failcount' -- "$@"`
> 
> 2:
> -Q|--quiet|-D|--delete-attr|-G|--get-value|-V) options="$options $1";
> sh
> ift;;
> 
> In both lines the --query is missing; However it's not missing in the
> usage message:
>             echo "Commands:"
>             echo " -G, --query          Query the current value of
> the attribute
> /option"
> 
> BTW: Also fix themanual page's "NAME" which is against the UNIX
> conventions ( NAME - The name of this manual page.):
> NAME
>        Pacemaker - Part of the Pacemaker cluster resource manager
> 
> SYNOPSIS
>        crm_failcount -r resource_name command [options]
> 
> 
> Regards,
> Ulrich
> 
> 
> _______________________________________________
> Users mailing list: Users at clusterlabs.org
> https://lists.clusterlabs.org/mailman/listinfo/users
> 
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.
> pdf
> Bugs: http://bugs.clusterlabs.org
-- 
Ken Gaillot <kgaillot at redhat.com>