[ClusterLabs] [Problem] The crmd causes an error of xml.

[Ken Gaillot]

On 04/06/2017 08:49 AM, renayama19661014 at ybb.ne.jp wrote:
> Hi All,
> 
> I confirmed a development edition of Pacemaker.
>  - https://github.com/ClusterLabs/pacemaker/tree/71dbd128c7b0a923c472c8e564d33a0ba1816cb5
> 
> ----
> property no-quorum-policy="ignore" \
>         stonith-enabled="true" \
>         startup-fencing="false"
> 
> rsc_defaults resource-stickiness="INFINITY" \
>         migration-threshold="INFINITY"
> 
> fencing_topology \
>         rh73-01-snmp: prmStonith1-1 \
>         rh73-02-snmp: prmStonith2-1
> 
> primitive prmDummy ocf:pacemaker:Dummy \
>         op start interval="0s" timeout="60s" on-fail="restart" \
>         op monitor interval="10s" timeout="60s" on-fail="restart" \
>         op stop interval="0s" timeout="60s" on-fail="fence"
> 
> primitive prmStonith1-1 stonith:external/ssh \
>         params \
>         pcmk_reboot_retries="1" \
>         pcmk_reboot_timeout="40s" \
>         hostlist="rh73-01-snmp" \
>         op start interval="0s" timeout="60s" on-fail="restart" \
>         op stop interval="0s" timeout="60s" on-fail="ignore"
> 
> primitive prmStonith2-1 stonith:external/ssh \
>         params \
>         pcmk_reboot_retries="1" \
>         pcmk_reboot_timeout="40s" \
>         hostlist="rh73-02-snmp" \
>         op start interval="0s" timeout="60s" on-fail="restart" \
>         op stop interval="0s" timeout="60s" on-fail="ignore"
> 
> ### Resource Location ###
> location rsc_location-1 prmDummy \
>         rule  300: #uname eq rh73-01-snmp \
>         rule  200: #uname eq rh73-02-snmp
> 
> ----
> 
> I pour the following brief crm files.
> I produce the trouble of the resource in a cluster.
> Then crmd causes an error.
> 
> ----
> (snip)
> Apr  6 18:04:22 rh73-01-snmp pengine[5214]: warning: Calculated transition 4 (with warnings), saving inputs in /var/lib/pacemaker/pengine/pe-warn-0.bz2
> Apr  6 18:04:22 rh73-01-snmp crmd[5215]:   error: XML Error: Entity: line 1: parser error : Specification mandate value for attribute CRM_meta_fail_count_prmDummy
> Apr  6 18:04:22 rh73-01-snmp crmd[5215]:   error: XML Error: rh73-01-snmp" on_node_uuid="3232238265"><attributes CRM_meta_fail_count_prmDummy
> Apr  6 18:04:22 rh73-01-snmp crmd[5215]:   error: XML Error:                                                                                ^
> Apr  6 18:04:22 rh73-01-snmp crmd[5215]:   error: XML Error: Entity: line 1: parser error : attributes construct error
> Apr  6 18:04:22 rh73-01-snmp crmd[5215]:   error: XML Error: rh73-01-snmp" on_node_uuid="3232238265"><attributes CRM_meta_fail_count_prmDummy
> Apr  6 18:04:22 rh73-01-snmp crmd[5215]:   error: XML Error:                                                                                ^
> Apr  6 18:04:22 rh73-01-snmp crmd[5215]:   error: XML Error: Entity: line 1: parser error : Couldn't find end of Start Tag attributes line 1
> Apr  6 18:04:22 rh73-01-snmp crmd[5215]:   error: XML Error: rh73-01-snmp" on_node_uuid="3232238265"><attributes CRM_meta_fail_count_prmDummy
> Apr  6 18:04:22 rh73-01-snmp crmd[5215]:   error: XML Error:                                                                                ^
> Apr  6 18:04:22 rh73-01-snmp crmd[5215]: warning: Parsing failed (domain=1, level=3, code=73): Couldn't find end of Start Tag attributes line 1
> (snip)
> ----
> 
> The XML that a new trouble count was related to somehow or other seems to have a problem.
> 
> I attach pe-warn-0.bz2.
> 
> Best Regards,
> Hideo Yamauchi.

Hi Hideo,

Thanks for the report!

This appears to be a PE bug when fencing is needed due to stop failure.
It wasn't caught in regression testing because the PE will continue to
use the old-style fail-count attribute if the DC does not support the
new style, and existing tests obviously have older DCs. I definitely
need to add some new tests.

I'm not sure why fail-count and last-failure are being added as
meta-attributes in this case, or why incorrect XML syntax is being
generated, but I'll investigate.