[ClusterLabs] Antw: crmsh configure delete for constraints

[Ulrich Windl]

Hi!

I guess it's hard to guess what the cluster will do when you remove constraints.
Maybe adding a keyword like "delete --no-wait ..." moves the risk to the operator...
However I'm not quite sure I understood your problem fully.

Regards,
Ulrich

>>> Vladislav Bogdanov <bubble at hoster-ok.com> schrieb am 08.02.2016 um 14:48 in
Nachricht <56B89CAF.8090809 at hoster-ok.com>:
> Hi,
> 
> when performing a delete operation, crmsh (2.2.0) having -F tries
> to stop passed op arguments and then waits for DC to become idle.
> 
> That is not needed if only constraints are passed to delete.
> Could that be changed? Or, could it wait only if there is something to stop?
> 
> Something like this:
> diff --git a/modules/ui_configure.py b/modules/ui_configure.py
> index cf98702..96ab77e 100644
> --- a/modules/ui_configure.py
> +++ b/modules/ui_configure.py
> @@ -552,6 +552,9 @@ class CibConfig(command.UI):
>              if not ok or not cib_factory.commit():
>                  raise ValueError("Failed to stop one or more running 
> resources: %s" %
>                                   (', '.join(to_stop)))
> +            return True
> +        else:
> +            return False
>  
>      @command.skill_level('administrator')
>      @command.completers_repeating(_id_list)
> @@ -562,8 +565,8 @@ class CibConfig(command.UI):
>          arg_force = any((x in ('-f', '--force')) for x in argl)
>          argl = [x for x in argl if (x not in ('-f', '--force'))]
>          if arg_force or config.core.force:
> -            self._stop_if_running(argl)
> -            utils.wait4dc(what="Stopping %s" % (", ".join(argl)))
> +            if (self._stop_if_running(argl)):
> +                utils.wait4dc(what="Stopping %s" % (", ".join(argl)))
>          return cib_factory.delete(*argl)
>  
>      @command.name('default-timeouts')
> 
> 
> More, it may be worth checking stop-orphan-resources property and pass stop
> work to pacemaker if it is set to true.
> 
> 
> Thank you,
> Vladislav
> 
> _______________________________________________
> Users mailing list: Users at clusterlabs.org 
> http://clusterlabs.org/mailman/listinfo/users 
> 
> Project Home: http://www.clusterlabs.org 
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf 
> Bugs: http://bugs.clusterlabs.org