[ClusterLabs] Small bug in RA heartbeat/syslog-ng

[Dejan Muhamedagic]

Hi,

On Mon, Sep 21, 2015 at 09:01:07AM +0200, Ulrich Windl wrote:
> Hi!
> 
> Just a small notice: While having a look at the syslog-ng RA, I found this bug (in SLES11 SP3, resource-agents-3.9.5-0.37.38.19):
> SYSLOG_NG_EXE="${OCF_RESKEY_syslog_ng_binary-/sbin/syslog-ng}" ### line 237 of /usr/lib/ocf/resource.d/heartbeat/syslog-ng
> 
> I tried it in BASH, but if {OCF_RESKEY_syslog_ng_binary is unset, the default won't be substituted. It's because the correct syntax is:
> SYSLOG_NG_EXE="${OCF_RESKEY_syslog_ng_binary:-/sbin/syslog-ng}"

Yes. Interestingly, there's some code to handle that case (but
commented out):

# why not default to /sbin/syslog-ng?
#if [[ -z "$SYSLOG_NG_EXE" ]]; then
#   ocf_log err "Undefined parameter:syslog_ng_binary"
#   exit $OCF_ERR_CONFIGURED
#fi

Thanks for the heads up!

Cheers,

Dejan

> Regards,
> Ulrich
> 
> 
> 
> _______________________________________________
> Users mailing list: Users at clusterlabs.org
> http://clusterlabs.org/mailman/listinfo/users
> 
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://bugs.clusterlabs.org