[Pacemaker] Operation attribute change leads to resource restart

[Vladislav Bogdanov]

Hi!

Just noticed that deletion of a trace_ra op attribute forces resource
to be restarted (that RA does not support reload).

Logs show:
Nov 13 09:06:05 [6633] node01        cib:     info: cib_process_request:    Forwarding cib_apply_diff operation for section 'all' to master (origin=local/cibadmin/2)
Nov 13 09:06:05 [6633] node01        cib:     info: cib_perform_op:     Diff: --- 0.641.96 2
Nov 13 09:06:05 [6633] node01        cib:     info: cib_perform_op:     Diff: +++ 0.643.0 98ecbda94c7e87250cf2262bf89f43e8
Nov 13 09:06:05 [6633] node01        cib:     info: cib_perform_op:     -- /cib/configuration/resources/clone[@id='cl-test-instance']/primitive[@id='test-instance']/operations/op[@id='test-instance-start-0']/instance_attributes[@id='test-instance-start-0-instance_attributes']
Nov 13 09:06:05 [6633] node01        cib:     info: cib_perform_op:     +  /cib:  @epoch=643, @num_updates=0
Nov 13 09:06:05 [6633] node01        cib:     info: cib_process_request:    Completed cib_apply_diff operation for section 'all': OK (rc=0, origin=node01/cibadmin/2, version=0.643.0)
Nov 13 09:06:05 [6638] node01       crmd:     info: abort_transition_graph:     Transition aborted by deletion of instance_attributes[@id='test-instance-start-0-instance_attributes']: Non-status change (cib=0.643.0, source=te_update_diff:383, path=/cib/configuration/resources/clone[@id='cl-test-instance']/primitive[@id='test-instance']/operations/op[@id='test-instance-start-0']/instance_attributes[@id='test-instance-start-0-instance_attributes'], 1)
Nov 13 09:06:05 [6638] node01       crmd:   notice: do_state_transition:    State transition S_IDLE -> S_POLICY_ENGINE [ input=I_PE_CALC cause=C_FSA_INTERNAL origin=abort_transition_graph]
Nov 13 09:06:05 [6634] node01 stonith-ng:     info: xml_apply_patchset:     v2 digest mis-match: expected 98ecbda94c7e87250cf2262bf89f43e8, calculated 0b344571f3e1bb852e3d10ca23183688
Nov 13 09:06:05 [6634] node01 stonith-ng:   notice: update_cib_cache_cb:    [cib_diff_notify] Patch aborted: Application of an update diff failed (-206)
...
Nov 13 09:06:05 [6637] node01    pengine:     info: check_action_definition:    params:reload   <parameters boot_directory="/var/lib/libvirt/boot" config_uri="http://192.168.168.10:8080/cgi-bin/manage_config.cgi?action=%a&resource=%n&instance=%i" start_vm="1" vlan_id_start="2" per_vlan_ip_prefix_len="24" base_img="http://192.168.168.10:8080/pre45-mguard-virt.x86_64.default.qcow2" pool_name="default" outer_phy="eth0" ip_range_prefix="10.101.0.0/16"/>
Nov 13 09:06:05 [6637] node01    pengine:     info: check_action_definition:    Parameters to test-instance:0_start_0 on rnode001 changed: was 6f9eb6bd1f87a2b9b542c31cf1b9c57e vs. now 02256597297dbb42aadc55d8d94e8c7f (reload:3.0.9) 0:0;41:3:0:95e66b6a-a190-4e61-83a7-47165fb0105d
...
Nov 13 09:06:05 [6637] node01    pengine:   notice: LogActions:     Restart test-instance:0 (Started rnode001)

That is not what I'd expect to see.
Is it intended or just a minor bug(s)?

Best,
Vladislav