[Pacemaker] killproc not found? o2cb shutdown via resource agent

[Matthew O'Connor]

I'm honestly beginning to wonder what exactly that killproc does for the
ocfs2_controld.cman process... For kicks, I created a script in /sbin
and /usr/sbin for killproc, which simply sources the lsb include and
calls the function with whatever was passed via the command-line. 
Perhaps an equivalent fix to modifying the RA or the included shell
extensions file, but still not as friendly as installing a .deb. ;-) 

However, I'm not sure if it's doing anything useful, even though I can
see (via echos) that it's being called.  The ocfs2_controld.cman process
doesn't go away till pacemaker is stopped (and isn't started until
pacemaker is running and the node is online), which blunders into
another problem: the o2cb RA appears to be in charge of unloading any
modules it loaded, but it fails to unload the ocfs2_stack_user module. 
This causes CMAN to fail when shutting down; manually running 'service
o2cb stop' before 'service cman stop' resolves the problem, but I would
believe the RA should be doing this.  Even when the ocfs2_controld.cman
process dies with pacemaker, the module remains.  :-/


On 11/08/2012 06:02 AM, Dejan Muhamedagic wrote:
> Hi,
>
> On Thu, Nov 08, 2012 at 08:23:53PM +1100, Tim Serong wrote:
>> On 11/08/2012 07:56 PM, Andrew Beekhof wrote:
>>> On Thu, Nov 8, 2012 at 5:16 PM, Tim Serong <tserong at suse.com> wrote:
>>>> On 11/08/2012 12:11 PM, Andrew Beekhof wrote:
>>>>> On Thu, Nov 8, 2012 at 9:59 AM, Matthew O'Connor <matt at ecsorl.com> wrote:
>>>>>> Follow-up and additional info:
>>>>>>
>>>>>> System is Ubuntu 12.04.  Not sure where killproc is supposed to be derived
>>>>>> from, or if there is an assumption for it to be a standalone binary or
>>>>>> script.  I did find it defined in /lib/lsb/init-functions.  Adding a ".
>>>>>> /lib/lsb/init-functions" to the start of the
>>>>>> /usr/lib/ocf/resource.d/heartbeat/.ocf-shellfuncs file makes the
>>>>>> process-kill work, but I suspect this is not the most desirable solution.
>>>>> I think thats as good a solution as any.
>>>>> I wonder where other distros are getting it from.
>>>> SLES 11 SP2:
>>>>
>>>> # rpm -qf /sbin/killproc
>>>> sysvinit-2.86-210.1
>>>>
>>>> openSUSE 12.2:
>>>>
>>>> # rpm -qf /sbin/killproc
>>>> sysvinit-tools-2.88+-77.3.1.x86_64
>>>>
>>>> Can't speak for any others offhand...
>>> Definitely not on fedora or its derivatives
>> Hrm.  Well, I just had a quick skim of the ocfs2-tools source, and I'd
>> be willing to bet the o2cb RA was based on the upstream o2cb init
>> script, which uses killproc, but also sources /lib/lsb/init-functions.
>> Does Fedora have killproc buried somewhere in there maybe?
>>
>> On SUSE, /lib/lsb/init-functions defines start_daemon(), killproc(), and
>> pidofproc() but these just wrap binaries of the same name in /sbin
>> (which would explain why o2cb works fine on SUSE, as those "missing"
>> things are presumably in $PATH anyway).
>>
>> I don't know about sourcing /lib/lsb/init-functions in .ocf-shellfuncs -
>> might be a bit broad?  Presumably couldn't hurt to source it in the o2cb
>> RA though, unless there's some other cleaner solution...
> I'd also say just in this particular RA. Unfortunately, the
> distro specific stuff creeps now and again into agents supposed
> to work everywhere.
>
> Cheers,
>
> Dejan
>
>> Regards,
>>
>> Tim
>> -- 
>> Tim Serong
>> Senior Clustering Engineer
>> SUSE
>> tserong at suse.com
>>
>> _______________________________________________
>> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
>> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>>
>> Project Home: http://www.clusterlabs.org
>> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
>> Bugs: http://bugs.clusterlabs.org
> _______________________________________________
> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://bugs.clusterlabs.org


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5029 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://lists.clusterlabs.org/pipermail/pacemaker/attachments/20121108/eb1edf7d/attachment-0003.p7s>