[Pacemaker] Pure-FTPd resource script is wrong (at least on ubuntu and probably debian)

[Mailing List SVR]

Il 12/11/2011 11:26, Stefan Hornburg (Racke) ha scritto:
> On 11/11/2011 01:43 PM, Raoul Bhatia [IPAX] wrote:
>> hi!
>>
>> as i'm quote familiar with the pure-ftpd script, i'm stepping into
>> this conversation.
>>
>> On 2011-11-10 18:40, Mailing List SVR wrote:
>>> 1) I have this primitive:
>>>
>>> primitive ftp_service ocf:heartbeat:Pure-FTPd \
>>> params script="/usr/sbin/pure-ftpd-wrapper" daemon_type="postgresql"
>>> pidfile="/var/run/pure-ftpd/pure-ftpd.pid" \
>>> op monitor interval="40s" timeout="20s" \
>>> op start interval="0" timeout="20s" \
>>> op stop interval="0" timeout="20s"
>>
>> looks good.
>>
>>
>>> please note that I'm passing pidfile parameter to the RA script and 
>>> that
>>> on debian/ubuntu pidfile is hardcoded to
>>> "/var/run/pure-ftpd/pure-ftpd.pid" so this is the only available choice
>>
>> what do you mean by that? where is the pidfile hardcoded?
>>
>> you mean in /usr/sbin/pure-ftpd-wrapper line 172?
>>
>> well, then this is, imho, the problem of debian/ubuntu's warpper
>> script not creating the correct directory.
>>
>> > # force PID file to /var/run/pure-ftpd/pure-ftpd.pid
>> > push(@options, '-g', '/var/run/pure-ftpd/pure-ftpd.pid');
>>
>> /var/run/pure-ftpd/ is created by the init script "on the fly".
>> this patch comes from http://bugs.debian.org/506077 and might as well
>> be replaced/complemented by additional checks in the, debian specific,
>> wrapper script.
>>
>> you better send a corresponding bugreport - or even better a patch -
>> to Stefan Hornburg (Racke) <racke at linuxia.de> and/or the debian/ubuntu
>> bugtracker.
>>
>> there is "nothing" that the resource agent can be blamed for.
>
> So the proposed changes for Debian package are:
>
> * move directory creation into wrapper script
> * make location of PID file configurable
>
> Please comment if I got that right.

yes that would be another good solution,

Nicola

>
> Regards
>     Racke
>