[Pacemaker] [PATCH]Bug 2567 - crm resource migrate should support an optional "role" parameter

Andrew Beekhof andrew at beekhof.net
Fri Apr 29 07:41:57 UTC 2011


On Thu, Apr 28, 2011 at 9:53 AM, Holger Teutsch <holger.teutsch at web.de> wrote:
> Hi Dejan,
>
> On Tue, 2011-04-26 at 17:58 +0200, Dejan Muhamedagic wrote:
>> Hi Holger,
>>
>> On Sun, Apr 24, 2011 at 04:31:33PM +0200, Holger Teutsch wrote:
>> > On Mon, 2011-04-11 at 20:50 +0200, Andrew Beekhof wrote:
>> > > why?
>> > >         CMD_ERR("Resource %s not moved:"
>> > >                 " specifying --master is not supported for
>> > > --move-from\n", rsc_id);
>> > >
>> > it did not look sensible to me but I can't recall the exact reasons 8-)
>> > It's now implemented.
>> > > also the legacy handling is a little off - do a make install and run
>> > > tools/regression.sh and you'll see what i mean.
>> >
>> > Remaining diffs seem to be not related to my changes.
>> >
>> > > other than that the crm_resource part looks pretty good.
>> > > can you add some regression testcases in tools/ too please?
>> > >
>> > Will add them once the code is in the repo.
>> >
>> > Latest diffs are attached.
>>
>> The diffs seem to be against the 1.1 code, but this should go
>> into the devel repository. Can you please rebase the patches
>> against the devel code.
>>
> Unfortunately the devel code does not run at all in my environment so I
> have to fix this first.

Oh?  I ran CTS on it the other day and it was fine here.




More information about the Pacemaker mailing list