[Pacemaker] Proposing patch for ld --as-needed

Simon Horman horms at verge.net.au
Mon Jul 26 07:58:09 UTC 2010


On Mon, Jul 26, 2010 at 09:32:20AM +0200, Andrew Beekhof wrote:
> On Mon, Jul 26, 2010 at 9:26 AM, Simon Horman <horms at verge.net.au> wrote:
> > On Thu, Jul 22, 2010 at 05:05:07PM +0900, Simon Horman wrote:
> >> > # This patch sets the build processs 'ld --as-needed' compliant
> >> > #
> >> > # First chunck corrects the linking order so that libpe_status is linked
> >> > # after libpengine. This is needed because the linker evaluates statements
> >> > # sequentially starting from the inner most lib and libpengine uses functions
> >> > # that are defined in libpe_status.
> >> > #
> >> > # Second chunck explicitly adds CURSESLIBS dependency to libpe_status.
> >> > # This is requested from the configure.ac upon ncurses detection so we
> >> > # need to provide 'printw' or any linking with libpe_status will fail.
> >>
> >> This looks good to me.
> >
> > Andrew, Dejan,
> >
> > could you consider applying this change?
> 
> Done.

Thanks

> Forgot to give attribution though, sorry :-(

Thats fine by me :-)




More information about the Pacemaker mailing list