[Pacemaker] [PATCH] Build: fix fedora package interdependencies

[Vadym Chepkov]

On Fri, Dec 3, 2010 at 2:17 AM, Andrew Beekhof <andrew at beekhof.net> wrote:
> Libraries we link against are automatically added as dependancies by
> rpm, there's no need (and it is discouraged) to list them explicitly
>

I totally agree, the spec file is just inconsistent.

Then it needs to be adjusted this way, no?

diff --git a/pacemaker.spec b/pacemaker.spec
--- a/pacemaker.spec
+++ b/pacemaker.spec
@@ -75,12 +75,10 @@

 %if %{with esmtp}
 BuildRequires:	libesmtp-devel
-Requires:	libesmtp
 %endif

 %if %{with snmp}
 BuildRequires:	net-snmp-devel
-Requires:	net-snmp
 %endif

 %if %{with ais}
@@ -88,7 +86,7 @@
 %endif

 %if %{with heartbeat}
-BuildRequires:	heartbeat-devel heartbeat-libs
+BuildRequires:	heartbeat-devel
 %endif

 %description




> On Thu, Dec 2, 2010 at 4:09 PM, Vadym Chepkov <vchepkov at gmail.com> wrote:
>> # HG changeset patch
>> # User Vadym Chepkov <vchepkov at gmail.com>
>> # Date 1291302502 18000
>> # Branch stable-1.0
>> # Node ID b517ca7d84e972e10e1013faff00fa6fd430a165
>> # Parent  b2e39d318fda501e2fcf223c2d039b721f3679a9
>> Build: fix fedora package interdependencies
>>
>> diff --git a/pacemaker.spec b/pacemaker.spec
>> --- a/pacemaker.spec
>> +++ b/pacemaker.spec
>> @@ -85,10 +85,12 @@
>>
>>  %if %{with ais}
>>  BuildRequires: corosynclib-devel
>> +Requires:      corosynclib
>>  %endif
>>
>>  %if %{with heartbeat}
>> -BuildRequires: heartbeat-devel heartbeat-libs
>> +BuildRequires: heartbeat-devel
>> +Requires:      heartbeat-libs
>>  %endif
>>
>>  %description
>>
>> _______________________________________________
>> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
>> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>>
>> Project Home: http://www.clusterlabs.org
>> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
>> Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker
>>
>
> _______________________________________________
> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker
>