[Pacemaker] what's the deal with 1.0.9 init_ais_connection?

[Andrew Beekhof]

On Tue, Aug 3, 2010 at 7:18 PM, Alan Jones <falancluster at gmail.com> wrote:
> I'm trying to work a cib seg fault in init_ais_connection() for pacemaker
> 1.0.9.

Don't. Use 1.0.9.1 which already has the patch below.

> The 1.0.8 version of this function is pretty stright forward, calling one of
> the
> comm stack's connect functions depending on the config.
> In 1.0.9, however, it appears to be a recursive call that never ends.
> There is also a init_ais_connection_once() below that appears to be the
> intended function to call within this function.
> Is it safe for me to make this change?
> Alan
> ---
> ajones at ajones-dl:~/hasrc/Pacemaker-1-0-Pacemaker-1.0.9/lib/common$ diff -c
> ais.c.org ais.c
> *** ais.c.org    2010-06-23 03:25:30.000000000 -0700
> --- ais.c    2010-08-03 10:20:38.320875334 -0700
> ***************
> *** 582,588 ****
>   {
>       int retries = 0;
>       while(retries++ < 30) {
> !     int rc = init_ais_connection(dispatch, destroy, our_uuid, our_uname,
> nodeid);
>       switch(rc) {
>           case CS_OK:
>           return TRUE;
> --- 582,588 ----
>   {
>       int retries = 0;
>       while(retries++ < 30) {
> !     int rc = init_ais_connection_once(dispatch, destroy, our_uuid,
> our_uname, nodeid);
>       switch(rc) {
>           case CS_OK:
>           return TRUE;
>
>
> _______________________________________________
> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs:
> http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker
>
>