[Pacemaker] New patch for System Health feature

Andrew Beekhof andrew at beekhof.net
Wed May 13 19:08:36 UTC 2009


On Wed, May 13, 2009 at 5:07 PM, Mark Hamzy <hamzy at us.ibm.com> wrote:
> Okay, here is attempt #2:
>
> (See attached file: pacemaker.mark.patch)
>
> Questions/comments?

This is missing the modification to char2score that i mentioned (which
would also simplify calculate_system_health()).

You'd only want to call initialize_health_value() for the "custom" strategy.
The migrate-on-* strategies would simply set the appropriate values.

Oh, and initialize_health_value() should probably just set a something
in data_set (which would be passed to char2score) and should obtain a
value from data_set->config_hash instead of using an xpath query.

For extra credit, you could also fake the configuration element and
pass it to generate_location_rule() instead of using rsc2node_new().
This is what I orginally had in mind, but may not be worth the effort.




More information about the Pacemaker mailing list