<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
Hey Ken,<br>
<br>
Thought so, thank you for confirming!<br>
<br>
Gerry Sommerville<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Developers <developers-bounces@clusterlabs.org> on behalf of Ken Gaillot <kgaillot@redhat.com><br>
<b>Sent:</b> Wednesday, February 23, 2022 5:06 PM<br>
<b>To:</b> developers@clusterlabs.org <developers@clusterlabs.org><br>
<b>Subject:</b> [EXTERNAL] Re: [ClusterLabs Developers] crmadmin</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Wed, 2022-02-23 at 21:26 +0000, Gerry R Sommerville wrote:<br>
> Hey devs,<br>
> <br>
> I noticed there was a change in exit code from crmadmin --version<br>
> from version 2.0.4 to 2.0.5, I run this command in a script which<br>
> checks if [[ 0 -ne $? ]]; then .... which is how I noticed the<br>
> change.<br>
> <br>
> In 2.0.4, crmadmin would exit with 0, while in 2.0.5 it will exit<br>
> with 64. Ran this through gdb quick as well and here are the<br>
> respective traces.<br>
<br>
That was in fact a bug in 2.0.5, fixed in 2.1.0. The bug and fix were<br>
both side effects of other changes, so it wasn't noticed until you did<br>
:) and it wasn't in the ChangeLog.<br>
<br>
> <br>
> Pacemaker 2.0.4<br>
> Thread 1 (Thread 0x7ffff7fc9b80 (LWP 3423363)):<br>
> #0 0x00007ffff5190c20 in exit () from /lib64/libc.so.6<br>
> #1 0x00007ffff70c00b4 in crm_exit (rc=rc@entry=CRM_EX_OK) at<br>
> results.c:773<br>
> #2 0x00007ffff70b63f6 in pcmk__cli_help (cmd=<optimized out>,<br>
> exit_code=CRM_EX_OK) at options.c:263<br>
> #3 0x0000555555556084 in main (argc=2, argv=0x7fffffffd738) at<br>
> crmadmin.c:183<br>
> <br>
> <br>
> Pacemaker 2.0.5<br>
> Thread 1 (Thread 0x7ffff7fd6b80 (LWP 2880544)):<br>
> #0 0x00007ffff5184c20 in exit () from /lib64/libc.so.6<br>
> #1 0x00007ffff70be6e4 in crm_exit (rc=rc@entry=CRM_EX_USAGE) at<br>
> results.c:781<br>
> #2 0x00007ffff70aed96 in pcmk__cli_help (cmd=<optimized out>,<br>
> exit_code=CRM_EX_USAGE) at options.c:264<br>
> #3 0x00005555555563d5 in main (argc=2, argv=0x7fffffffe058) at<br>
> crmadmin.c:426<br>
> <br>
> I am wondering if this change was intentional, or a bug introduced by<br>
> some other change. I believe its a bug since crmadmin -h still exits<br>
> with 0.<br>
> <br>
> Gerry Sommerville<br>
> _______________________________________________<br>
> Manage your subscription:<br>
> <a href="https://lists.clusterlabs.org/mailman/listinfo/developers">https://lists.clusterlabs.org/mailman/listinfo/developers</a>
<br>
> <br>
> ClusterLabs home: <a href="https://www.clusterlabs.org/">https://www.clusterlabs.org/</a>
<br>
-- <br>
Ken Gaillot <kgaillot@redhat.com><br>
<br>
_______________________________________________<br>
Manage your subscription:<br>
<a href="https://lists.clusterlabs.org/mailman/listinfo/developers">https://lists.clusterlabs.org/mailman/listinfo/developers</a>
<br>
<br>
ClusterLabs home: <a href="https://www.clusterlabs.org/">https://www.clusterlabs.org/</a>
<br>
</div>
</span></font></div>
</body>
</html>