[ClusterLabs Developers] compiling Cluster Glue 1.0.12

[pierre-philipp braun]

Hello there

on a Slackware64 14.2 system, with GCC,

# gcc -v
Reading specs from /usr/lib64/gcc/x86_64-slackware-linux/5.5.0/specs
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-slackware-linux/5.5.0/lto-wrapper
Target: x86_64-slackware-linux
Configured with: ../gcc-5.5.0/configure --prefix=/usr --libdir=/usr/lib64 --mandir=/usr/man --infodir=/usr/info --enable-shared --enable-bootstrap --enable-languages=ada,c,c++,fortran,go,java,lto,objc --enable-threads=posix --enable-checking=release --enable-objc-gc --with-system-zlib --with-python-dir=/lib64/python2.7/site-packages --enable-libstdcxx-dual-abi --with-default-libstdcxx-abi=gcc4-compatible --disable-libunwind-exceptions --enable-__cxa_atexit --enable-libssp --enable-lto --disable-install-libiberty --with-gnu-ld --verbose --enable-java-home --with-java-home=/usr/lib64/jvm/jre --with-jvm-root-dir=/usr/lib64/jvm --with-jvm-jar-dir=/usr/lib64/jvm/jvm-exports --with-arch-directory=amd64 --with-antlr-jar=/home/slackware/slackbuilds/gcc-5.5.0/antlr-runtime-3.4.jar --enable-multilib --target=x86_64-slackware-linux --build=x86_64-slackware-linux --host=x86_64-slackware-linux
Thread model: posix
gcc version 5.5.0 (GCC) 

when compiling the current release of Cluster Glue, version 1.0.12, I get,

# make -j16 >/dev/null && echo done
cl_msg.c: In function 'cl_msg_add_list_str':
cl_msg.c:1347:13: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
          !n <= 0?"n is negative or zero": 
             ^
cl_msg.c: In function 'cl_msg_add_list_int':
cl_msg.c:1400:13: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
          !n <= 0?"n is negative or zero": 
             ^
cc1: all warnings being treated as errors
gmake[2]: *** [cl_msg.lo] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1

the parts of `lib/clplumbing/cl_msg.c` that maybe have bugs,

  1344          if (n <= 0  || buf == NULL|| name ==NULL ||msg == NULL){
  1345                  cl_log(LOG_ERR, "%s:"
  1346                         "invalid parameter(%s)",
  1347                         !n <= 0?"n is negative or zero":
  1348                         !buf?"buf is NULL":
  1349                         !name?"name is NULL":
  1350                         "msg is NULL",__FUNCTION__);
  1351                  return HA_FAIL;
  1352          }

  1397          if (n <= 0  || buf == NULL|| name ==NULL ||msg == NULL){
  1398                  cl_log(LOG_ERR, "cl_msg_add_list_int:"
  1399                         "invalid parameter(%s)",
  1400                         !n <= 0?"n is negative or zero":
  1401                         !buf?"buf is NULL":
  1402                         !name?"name is NULL":
  1403                         "msg is NULL");
  1404                  goto free_and_out;
  1405          }

Should I report a bug or can you help me right now?  Should I provide some additional information?

Thanks