[ClusterLabs Developers] resource-agents v4.1.0 rc1

Kristoffer Grönlund kgronlund at suse.com
Fri Nov 17 16:04:04 UTC 2017


Dejan Muhamedagic <dejanmm at fastmail.fm> writes:

>> > > P.S. Right now irrelevant, but LVM-activate doesn't seem like a
>> > > good name.
>> > 
>> > If nothing else, it's in keeping with the rest of the mess of bad names
>> > ;) Maybe we should decide on a naming standard? Abbreviations or no
>> > abbreviations, CamelCase or lowercase, or lower_case? This could be
>> > enforced through the CI checks, and the Makefile could make sure to
>> > install aliases to the old names so as not to break existing
>> > installations.
>> I think we should keep them as is for current agents, but new agents
>> should be lowercase with an optional -'s if that clarifies their
>> usage.
>
> My point was that it is arguably a pleonasm. The "activate" part
> is superfluous. Sorry for not being clearer.
>
> As for bad names, we need to look no further than the LVM RA:
> in volgrpname the "name" part is just as much necessary.

While I agree that LVM-activate, being a verb, is not a great
name, I at least am having a hard time coming up with a good one. Naming
truly is the hardest part of programming...

I guess my general point was that we don't have any kind of guidelines
for naming that people can refer to, resulting in the amazing variety of
names both in style and semantics that we're stuck with now.

We had this discussion before and decided it was as much trouble as it
solves to change things, but I still haven't given up on the idea ;)
There's also the topic of the heartbeat provider being completely
outdated and continuing to confuse newcomers, especially considering
Pacemaker now dropping heartbeat support completely as of version
2. Maybe that would be the time to introduce a new provider, with a more
strictly defined standard for agent and parameter naming for example.

>
>> > Maybe we could even move IPaddr2 to ip or IP, and move the now-outdated
>> > agents to a legacy provider...
>
> Yeah, I hope we don't need to get into that ;-)

Too late! Anyway, I'll try to let it go for now... ;)

Cheers,
Kristoffer

>
> Cheers,
>
> Dejan
>
>> > 
>> > Cheers,
>> > Kristoffer
>> > 
>> > > 
>> > > 
>> > > 
>> > > 
>> > > >  - minio
>> > > >  - NodeUtilization
>> > > >  - oraasm
>> > > >  - ovsmonitor
>> > > >  - rkt
>> > > >  - ZFS
>> > > > 
>> > > > - bugfixes and enhancements:
>> > > >  - aws*: fixes and improvements
>> > > >  - CTDB: fixes for newer versions
>> > > >  - CTDB: fix for --logfile being replaced with --logging
>> > > >  - DB2: fix HADR support for DB2 V98+
>> > > >  - docker: add docker-native healthcheck
>> > > >  - galera: fix for MariaDB 10.1.21+
>> > > >  - mysql: set correct master score after maintenance mode
>> > > >  - ocf-shellfuncs: improve locking (ocf_take_lock())
>> > > >  - pgsql: add support for PostgreSQL 10
>> > > >  - pgsql: allow dynamic membership
>> > > >  - rabbitmq-cluster: fix to work on Pacemaker remote nodes
>> > > > 
>> > > > The full list of changes for resource-agents is available at:
>> > > > https://github.com/ClusterLabs/resource-agents/blob/v4.1.0rc1/ChangeLog
>> > > > 
>> > > > Everyone is encouraged to download and test the new release candidate.
>> > > > We do many regression tests and simulations, but we can't cover all
>> > > > possible use cases, so your feedback is important and appreciated.
>> > > > 
>> > > > Many thanks to all the contributors to this release.
>> > > > 
>> > > > 
>> > > > Best,
>> > > > The resource-agents maintainers
>> > > > 
>> > > > _______________________________________________
>> > > > Developers mailing list
>> > > > Developers at clusterlabs.org
>> > > > http://lists.clusterlabs.org/mailman/listinfo/developers
>> > > 
>> > > _______________________________________________
>> > > Developers mailing list
>> > > Developers at clusterlabs.org
>> > > http://lists.clusterlabs.org/mailman/listinfo/developers
>> > > 
>> > 
>> > -- 
>> > // Kristoffer Grönlund
>> > // kgronlund at suse.com
>> > 
>> > _______________________________________________
>> > Developers mailing list
>> > Developers at clusterlabs.org
>> > http://lists.clusterlabs.org/mailman/listinfo/developers
>
> _______________________________________________
> Developers mailing list
> Developers at clusterlabs.org
> http://lists.clusterlabs.org/mailman/listinfo/developers
>

-- 
// Kristoffer Grönlund
// kgronlund at suse.com




More information about the Developers mailing list