[Pacemaker] [PATCH] crm_mon expansion patch

[Andrew Beekhof]

Not sure about this bit:

+    if(failcount > 0) {
+	printed = TRUE;
+	print_as(": Resource is failure!!");
+    }
+

Was there any reason you didn't use node->details->attrs (or
utilization) directly?
That would be simpler and wouldn't require (incorrectly) assuming that
there is only ever one set of attributes per node.

2010/3/3 Yuusuke IIDA <iidayuus at intellilink.co.jp>:
> Hi all,
>
>
> This patch is a thing to let crm_mon display the attribute value of the node.
> The details argued in the following threads.
> http://www.gossamer-threads.com/lists/linuxha/pacemaker/59168
>
> This function applies a patch to crm_mon.c to use it, and please install crm_mon.
> This patch is a change set of stable-1.0: I can apply to 15377.
> And I attach a "-A" option, and please carry out crm_mon.
>
> The main function is as follows.
>  *  I added a function to display the attribute value of the node.
>  -  When abnormality occurred in an attribute value of pingd; of the function
> to display a warning message added it.
>  -  Of the function that a list shows a warning message for indication of
> "fail-count" added it.
>  *  Originally I deleted it because the function to display an attribute value
> of implemented pingd was redundant.
>
> The attribute to show below excludes you from indication.
>  *  probe_complete
>  *  shutdown
>  *  terminate
>  *  fail-count*
>  *  last-failure*
>
> I want you to merge it into a source tree if you do not have any problem.
>
> Best Regards,
> IIDA Yuusuke
>
> I show below indication example.
>
> #  crm_mon -fA1
> ============
> Last updated:  26 Fri Feb 13:49:05 2010
> Stack:  openais
> Current DC:  node1 - partition with quorum
> Version:  1.0.7-049006f17277+ stable-1.0 tip
> Two two Nodes configured, expected votes
> Two Resources configured.
> ============
>
> Online:  [node1 node2]
>
>  Resource Group:  grpDummy
>     prmDummy1 (ocf::heartbeat:Dummy):  Started node2
>     prmDummy2 (ocf::heartbeat:Dummy):  Started node2
>     prmDummy3 (ocf::heartbeat:Dummy):  Started node2
>  Clone Set:  clnPingd
>     Started:  [node2 node1]
>
> Node Attributes:
> *  Node node2:
>    + default_ping_set                   :  0              :  Link is failure!!
>  (Expected=100)
> *  Node node1:
>    + default_ping_set                   :  100
>
> Migration summary:
> *  Node node2:
> *  Node node1:
>   prmDummy3:  migration-threshold=1 fail-count=1:  Resource is failure!!
>
> Failed actions:
>    prmDummy3_monitor_10000 (node=node1, call=13, rc=7, status=complete):  not
> running
> #
>
> _______________________________________________
> Pacemaker mailing list
> Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>
>