[Pacemaker] [PATCH] suggested bashism fixes

Lars Ellenberg lars.ellenberg at linbit.com
Tue Jul 6 19:06:23 EDT 2010


On Tue, Jul 06, 2010 at 04:29:55PM +0200, Raoul Bhatia [IPAX] wrote:
> On 07/06/2010 04:15 PM, Raoul Bhatia [IPAX] wrote:
> > # HG changeset patch
> > # User Raoul Bhatia [IPAX] <r.bhatia at ipax.at>
> > # Date 1278425714 -7200
> > # Branch stable-1.0
> > # Node ID b914d11e1e165fc0b559ebbfb70db0014da0c250
> > # Parent  338113649a70f80fe89ac0765035a79f70cb202f
> > suggested bashism fixes
> 
> i think i made a mistake and
>   lower_yellow_limit=$(({OCF_RESKEY_temp_lower_limit}+5))
> 
> should actually read
>   lower_yellow_limit=$((OCF_RESKEY_temp_lower_limit+5))

that needs to be
   lower_yellow_limit=$(( $OCF_RESKEY_temp_lower_limit+5))

(or, if you prefer, ${OCF_...})

withouth the $ it will still work in bash because of implicit numeric
context dereference rules, but not so in those shells you dropped the
"let" for, in the first place.

-- 
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com

DRBD® and LINBIT® are registered trademarks of LINBIT, Austria.




More information about the Pacemaker mailing list