[Pacemaker] patch: pingd RA

[Dejan Muhamedagic]

Hi Dominik,

On Tue, Mar 10, 2009 at 09:56:54AM +0100, Dominik Klein wrote:
> High: RA pingd: Set default ping interval to 1 instead of 0 seconds.
> Produced high load and traffic.

Applied,

Thanks,

Dejan

> xen-03:~ # cat /proc/loadavg
> 1.53 1.54 1.47 4/213 6733
> xen-03:~ # ps aux|grep pingd
> root      6735  0.0  0.0   5284   808 pts/1    S+   09:52   0:00 grep pingd
> root     17399 40.7  0.0  65316  1620 pts/1    S    08:59  21:35
> /usr/lib64/heartbeat/pingd -D -p /var/run//pingd-pingd -a pingd -d 5s -h
> 10.2.50.11 -h 10.2.50.40 -h 10.2.50.8 -h 10.2.50.102
> 
> And that's in an otherwise idle cluster.
> 
> Until the next release, I'd strongly encourage anyone using the
> pacemaker pingd RA to define an instance attribute "interval" with a
> sane value or apply this patch. But of course, that's just me.
> 
> Regards
> Dominik

> # HG changeset patch
> # User dk at in-telegence.net
> # Date 1236675007 -3600
> # Branch stable-1.0
> # Node ID 451c994699292f58f97f399ead5c397e21b80b6f
> # Parent  bc608cbd92f58c4a4568f22265deef40895d93ed
> High: RA pingd: Set default ping interval to 1 instead of 0 seconds. Produced high load and traffic.
> 
> diff -r bc608cbd92f5 -r 451c99469929 extra/resources/pingd
> --- a/extra/resources/pingd	Mon Mar 09 20:30:18 2009 +0100
> +++ b/extra/resources/pingd	Tue Mar 10 09:50:07 2009 +0100
> @@ -257,11 +257,11 @@
>  	*) ocf_log warn "You should have pidfile($OCF_RESKEY_pidfile) of absolute path!" ;;
>      esac
>  
> -# Check the update interval
> -    if ocf_is_decimal "$OCF_RESKEY_update" && [ $OCF_RESKEY_update -gt 0 ]; then
> +# Check the ping interval
> +    if ocf_is_decimal "$OCF_RESKEY_interval" && [ $OCF_RESKEY_interval -gt 0 ]; then
>  	:
>      else
> -	ocf_log err "Invalid update interval $OCF_RESKEY_update. It should be positive integer!"
> +	ocf_log err "Invalid ping interval $OCF_RESKEY_interval. It should be positive integer!"
>  	exit $OCF_ERR_ARGS
>      fi
>  
> @@ -276,6 +276,7 @@
>  
>  : ${OCF_RESKEY_options:=""}
>  : ${OCF_RESKEY_dampen:="5s"}
> +: ${OCF_RESKEY_interval:="1"}
>  : ${OCF_RESKEY_name:="pingd"}
>  : ${OCF_RESKEY_CRM_meta_interval:=0}
>  : ${OCF_RESKEY_CRM_meta_globally_unique:="true"}

> _______________________________________________
> Pacemaker mailing list
> Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker